Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setChildrenAllowed false has no effect in Valo theme #5106

Closed
vaadin-bot opened this issue Apr 24, 2014 · 1 comment
Closed

setChildrenAllowed false has no effect in Valo theme #5106

vaadin-bot opened this issue Apr 24, 2014 · 1 comment

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @magi42


Tree nodes show expansion indicators regardless of the setting.

This appears to be a theme problem - it only occurs with Valo, not with Reindeer. Reindeer deals with the setting by hiding the indicator on the v-tree-node-leaf, Valo doesn't.

It's also a bit odd that clicking an item where the expansion indicator would be located gives the item the v-tree-node-expanded style regardless of the setting. I would think that leaf nodes should never get the style. Also the aria-expanded attribute changes. I'd recommend fixing this as well, as the style could cause unexpected behaviour.


Imported from https://dev.vaadin.com/ issue #13643

@vaadin-bot
Copy link
Collaborator Author

Originally by @jouni


Only fixed in Valo theme, the widget still adds the extra class and attribute to leaf nodes. Created a separate ticket for that: #14029

@vaadin-bot vaadin-bot added the bug label Dec 10, 2016
@vaadin-bot vaadin-bot added this to the Vaadin 7.3.0.beta1 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant