Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug window styles should not be included in the base theme #5051

Closed
vaadin-bot opened this issue Apr 7, 2014 · 4 comments
Closed

Debug window styles should not be included in the base theme #5051

vaadin-bot opened this issue Apr 7, 2014 · 4 comments
Milestone
Vaadin 7.3.0.alpha2

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @jouni

The CSS styles and fonts for the debug window should be injected directly as a <style> to the HTML page (even in the case of embedded apps, like portlets).

The custom font should be included as a base64 encoded string. Internet Explorer 8 has a dataURL size limit of 32KB, which should not be a problem for the small debug icon set. Icomoon.io has the option to export the font as base64.

The injection should happen only when produtionMode==false and the ?debug parameter is used.

Imported from https://dev.vaadin.com/ issue #13563
@vaadin-bot
Copy link
Collaborator Author

Originally by @jdahlstrom

Related: #10356

@vaadin-bot
Copy link
Collaborator Author

Originally by @Artur-

We should implement this using GWT styling so the styles will automatically be excluded when the debug window code is excluded (production mode widget set). Then we don't need any custom handling.

@vaadin-bot
Copy link
Collaborator Author

Originally by @jouni

Embedding fonts using DataURI has two problems

  • GWT compiler doesn't know the mime type of fonts, they end up as content/unknown -> browsers fail to parse them
  • IE8 only supports DataURI's for images, not fonts -> no embedding for IE at all

@vaadin-bot
Copy link
Collaborator Author

Originally by @jouni

Debug styles now implemented as a separately downloaded asset (code-split).

@vaadin-bot vaadin-bot added this to the Vaadin 7.3.0.alpha2 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vaadin 7.3.0.alpha2
Development

No branches or pull requests
1 participant
@vaadin-bot