New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On the fly Scss compiler could cache result #2783
Comments
Originally by @hesara See also #14146 |
Originally by mrbrush I propose a patch to this issue, so that the cache staleness checking mechanism also considers URIs pointing to classloader resources which themselves are located as files in the filesystem (typical for maven based dynamic web projects with the Serve modules without publishing option checked in the Tomcat server config in Eclipse).
|
Originally by mrbrush Hmm, maybe also check for the URL's protocol, if it's |
Originally by @Legioth Replying to mrbrush:
Could you please create a separate ticket for this case, since this ticket has been closed for a while already. If you want, you can also directly submit a patch to our code review system: https://vaadin.com/wiki/-/wiki/Main/Contributing+Code |
Originally by @Artur-
The on the fly scss compiler in the servlet could cache the result and only recompile when there are changes. For this to work the scss compiler must be able to tell what files are used in the compilation process so the servlet can check the timestamps for these files.
By tracking max(timestamp) for the given styles.scss and the files used in the compilation the servlet can easily check if there are any modifications (any(timestamp) > max(timestamp)) to any files and only in that case recompile.
Imported from https://dev.vaadin.com/ issue #9532
The text was updated successfully, but these errors were encountered: