Publish DEPS for Chromium 39.0.2138.0
Disable some WebRtcBrowserTests under TSAN v2.
TBR=phoglund
NOTRY=true
BUG=408006
Review URL: https://codereview.chromium.org/506423002
Cr-Commit-Position: refs/heads/master@{#292120}
Add some IDs to the background mode packaged app whitelist.
BUG=405800
Review URL: https://codereview.chromium.org/510693002
Cr-Commit-Position: refs/heads/master@{#292119}
Centralize command line checks for kEnableStreamlinedHostedApps.
This moves all checks in the browser process into a common function.
BUG=368372
Review URL: https://codereview.chromium.org/489313002
Cr-Commit-Position: refs/heads/master@{#292118}
DevTools: remove methods used for native memory instrumentation
The instrumentation was dropped and the code is unused.
BUG=None
Review URL: https://codereview.chromium.org/510703002
Cr-Commit-Position: refs/heads/master@{#292117}
Fix NULL dereference in SearchProviderTest
BUG=407750
TEST=unit_tests
Review URL: https://codereview.chromium.org/511753002
Cr-Commit-Position: refs/heads/master@{#292116}
Disabled PasswordGenerationInteractiveTest.* as they are flaky.
TBR=gcasto
NOTRY=true
BUG=407998
Review URL: https://codereview.chromium.org/508893002
Cr-Commit-Position: refs/heads/master@{#292115}
Automated Commit: Committing new LKGM version 6204.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#292114}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/devtools/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/502293002
Cr-Commit-Position: refs/heads/master@{#292113}
Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/502203002
Cr-Commit-Position: refs/heads/master@{#292112}
Finish converting chrome_strings target to use qualified paths.
BUG=401588
Review URL: https://codereview.chromium.org/507913002
Cr-Commit-Position: refs/heads/master@{#292111}
ServiceWorker: Stop sending the SetVersionAttributes message from SWProviderHost
SWProviderHost had sent the SetVersionAttributes message to set version
attribtues of SWContainer (eg. navigator.serviceWorker.installing), but
these attributes were moved into SWRegistration and the message is now
sent from SWRegistrationHandle.
BUG=404982
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker
Review URL: https://codereview.chromium.org/496983002
Cr-Commit-Position: refs/heads/master@{#292110}
OOP PDF - Allow OOP PDF to use histograms
This patch adds libpdf.so to whitelisted plugins so that
it can use histograms. Without this patch, an error is
displayed every time when Chrome is launched with OOP PDF flag
and PDF file is opened.
BUG=405305
Review URL: https://codereview.chromium.org/508543002
Cr-Commit-Position: refs/heads/master@{#292109}
Add more logging to get information from plugin tests when they flake.
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/510673002
Cr-Commit-Position: refs/heads/master@{#292108}
Skia roll d3f6e89:5e8dbd3
https://skia.googlesource.com/skia/+log/d3f6e893df53fb0cfeefd01a8a49a77c72d742bd..5e8dbd31de0dff44aff83295bdfe518477a5a088
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/506403002
Cr-Commit-Position: refs/heads/master@{#292107}
(Reland) Service Worker: Handle same-scope, new script registration
Reland of 2da192aff after:
- disabling some layout tests that need to be rebaselined
- landing 6cce6b78f "Decouple script_url from ServiceWorkerRegistration"
so Registration doesn't get in a weird state with a script_url that failed to
register
Before this patch, register() would delete an existing registration at
the scope if the script URL didn't match, and register a new one. This
overwriting creates a scenario where old tabs have a different
controller than new tabs, which the Service Worker spec avoids.
This patch implements the spec steps for same-scope, new script
register(). That means:
- If the existing registration is uninstalling, wait for that to
complete before doing anything.
- Create a new worker which becomes the installing worker of the
existing registration.
BUG=398355
TEST=https://codereview.chromium.org/480943002/
Review URL: https://codereview.chromium.org/506043002
Cr-Commit-Position: refs/heads/master@{#292106}
Replacing "tap" with "touch" in the Contextual Search UI.
TBR=thestig
BUG=407904
Review URL: https://codereview.chromium.org/504253003
Cr-Commit-Position: refs/heads/master@{#292105}
Implement the host side of serial connection I/O on data pipe.
This change adds DataSource and DataSink interface request parameters to
SerialService::Connect, passes them through to SerialConnection
instances via SerialConnectionFactory; the SerialConnection now uses a
DataSourceSender and a DataSinkReceiver for implementing serial receive
and send, respectively.
BUG=389016
Review URL: https://codereview.chromium.org/488363002
Cr-Commit-Position: refs/heads/master@{#292104}
In about:gpu page, make sure feature status and problem description match
BUG=405354
TEST=about:gpu page for Win/NVIDIA with driver version forced to "", gpu_unittests
R=kbr@chromium.org
Review URL: https://codereview.chromium.org/503243002
Cr-Commit-Position: refs/heads/master@{#292103}
Minor changes to allow Pepper InstancePrivate tests to pass with gin
This includes some minor changes which allow tests to when NPObject is replaced
by gin in pepper:
-Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in
tests.
-Add gin as a dependency to content_unittests for use in host_var_tracker_unittest
-Change TestInstanceDeprecated so that it doesn't execute a script from the
ScriptableObject upon destruction. The reason for this is that the garbage
collector is manually run from the destructor of the plugin Instance object.
This results in destruction of the ScriptableObject and then javascript is
re-entered via ExecuteScript. This should never happen outside tests because
the garbage collector won't be run synchronously. Instead of running
ExecuteScript, which just set a variable in the Instance object to verify
that the ScriptableObject was correctly destroyed.
BUG=351636
Committed: https://chromium.googlesource.com/chromium/src/+/92c3074f4b4417924115f880657f1ec15da0e0ba
Review URL: https://codereview.chromium.org/472693002
Cr-Commit-Position: refs/heads/master@{#292102}
Revert of Cleanup: Remove unneeded SSE2 checks and unused code. (patchset #4 of https://codereview.chromium.org/459603003/)
Reason for revert:
Passed the win x64 trybot, but failed on the win 64 builder.
Original issue's description:
> Cleanup: Remove unneeded SSE2 checks and unused code.
>
> BUG=349320
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b2cd99b39c3744f61231f8818f6c7a3d2881f0f0
TBR=cpu@chromium.org,dalecurtis@chromium.org,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=349320
Review URL: https://codereview.chromium.org/513663002
Cr-Commit-Position: refs/heads/master@{#292101}
Cleanup: Remove unneeded SSE2 checks and unused code.
BUG=349320
Review URL: https://codereview.chromium.org/459603003
Cr-Commit-Position: refs/heads/master@{#292100}
history/compiled_resources.gyp added to third_party/closure_compiler/compiled_resources.gyp
BUG=393873
R=dbeam@chromium.org
Review URL: https://codereview.chromium.org/507933002
Cr-Commit-Position: refs/heads/master@{#292099}
For blink changes, the git cl upload isn't working correctly for me with 'origin/master' at the end.
I'm clearly not a git expert. Is there a better solution? If not, I'll add a test to this one.
BUG=
Review URL: https://codereview.chromium.org/469373006
Cr-Commit-Position: refs/heads/master@{#292098}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/sync_file_system/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/506793002
Cr-Commit-Position: refs/heads/master@{#292097}
Remove implicit conversions from scoped_refptr to T* in content/renderer/media/webrtc*
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/503683003
Cr-Commit-Position: refs/heads/master@{#292096}
Content verification: Don't fail on non-existence.
This prevents content verification (when active) from disabling
an extension when the extension attempts to load a non-existent
resource in its own chrome-extension URL space.
BUG=404802
Review URL: https://codereview.chromium.org/512573003
Cr-Commit-Position: refs/heads/master@{#292095}
Fix logic on high Windows resolution timer and have
two possible period values for timeBeginPeriod and timeEndPeriod.
Currently while on battery we disable calls to timeBeginPeriod
which make the windows timers have 15ms resolution.
This change makes it so when EnableHighResolutionTimer(true) which
is on AC power the timer is 1ms and EnableHighResolutionTimer(false)
is 4ms.
This should provide significant power savings while meeting some
timer resolution requirements needed by the GPU compositor.
But also this CL fixes the following:
EnableHighResolutionTimer() and ActivateHighResolutionTimer() are
pretty broken. This CL fixes most issues:
1- The existing logic fails to account that EnableHighResolutionTimer
can be called while the browser is running
2- All related functions need to be thread safe.
3- ActivateHighResolutionTimer was buggy.
BUG=153139
Review URL: https://codereview.chromium.org/489793003
Cr-Commit-Position: refs/heads/master@{#292094}
[telemetry] Use SetEvent signals instead of web server for IPPET power monitor.
Hopefully this will reduce flake and overhead from running the web server.
BUG=336558
TEST=Enable IppetPowerMonitor.CanMonitorPower(), then tools/telemetry/run_tests ippet on Windows.
Review URL: https://codereview.chromium.org/504333003
Cr-Commit-Position: refs/heads/master@{#292093}
Refactor the home card structure and introduce animation.
This CL includes the following refactorings:
- minimized home is simply a layer instead of views
- moves the mouse click handler of minimized home to home card impl
- home card now has the same size of the screen. Changing state is
now simply changing its position.
Then schedule the animation between BOTTOM state and CENTERED state.
BUG=398062
R=sadrul@chromium.org, oshima@chromium.org
TEST=manually on remote desktop
Review URL: https://codereview.chromium.org/478293004
Cr-Commit-Position: refs/heads/master@{#292092}
Add AppDelegate::ResizeWebContents
To stop directly depending on apps/window_size_sizer from AppWindow.
BUG=403726
TBR=cbentzel@chromium.org for include/namespace fix in chrome/browser/prerender/prerender_contents.cc
Review URL: https://codereview.chromium.org/503233003
Cr-Commit-Position: refs/heads/master@{#292091}
Reland 596ff54335b2a1b393af10657bc4945114f3beed - Split API bundle generation steps
* Fixed in this version: dependencies for *_api_registration on *_api.
Split bundle generation steps so that API registration is generated in browser, not common.
We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.
Fix a couple of dangling gyp issues also.
BUG=405226
TBR=scottmg@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/513633002
Cr-Commit-Position: refs/heads/master@{#292090}
Disable AppApiTest.AppProcessRedirectBack as its flaky.
BUG=341898
TBR=mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/511723002
Cr-Commit-Position: refs/heads/master@{#292089}
Skia roll 2a65a23:d3f6e89
https://skia.googlesource.com/skia/+log/2a65a238b0e688356aee09d08f3f8a317359b4d2..d3f6e893df53fb0cfeefd01a8a49a77c72d742bd
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/507863003
Cr-Commit-Position: refs/heads/master@{#292088}
Remove CompositingIOSurfaceTransformerTest valgrind suppressions.
The code was deleted at r290374.
BUG=227278
TBR=ccameron
Review URL: https://codereview.chromium.org/504023002
Cr-Commit-Position: refs/heads/master@{#292087}
Remove unused PPB_View_Dev
TBR=binji@chromium.org
Review URL: https://codereview.chromium.org/498123002
Cr-Commit-Position: refs/heads/master@{#292086}
Componentize SearchProvider
Move BaseSearchProvider, SearchProvider, AnswersCache to components/omnibox
BUG=388515
TBR=bauerb@chromium.org for include fix in chrome/browser/android/omnibox/autocomplete_controller_android.cc
Review URL: https://codereview.chromium.org/489353004
Cr-Commit-Position: refs/heads/master@{#292085}
Don't hide the scope in chrome://serviceworker-internals/.
Currently max-width is set in .serviceworker-scope.
So if the scope is too long, it could be hidden.
BUG=N/A
Review URL: https://codereview.chromium.org/506603003
Cr-Commit-Position: refs/heads/master@{#292084}
cc: Fix UAF in g_raster_required_for_activation_delay
g_raster_required_for_activation_delay is used after free. See bug for
details.
Fix by putting the delay object in RasterTaskGraphRunner which itself is
a leaky lazy instance.
BUG=402653
Review URL: https://codereview.chromium.org/498553005
Cr-Commit-Position: refs/heads/master@{#292083}
Remove implicit conversions from scoped_refptr to T* in media/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/506683002
Cr-Commit-Position: refs/heads/master@{#292082}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/sync/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/504273003
Cr-Commit-Position: refs/heads/master@{#292081}
Split AppListController::SetVisible into Show and Dismiss.
This CL is in preparation for passing a reason for showing the app list.
This split is necessary to pass a reason only when showing and not
when dismissing.
BUG=391348
Review URL: https://codereview.chromium.org/485453003
Cr-Commit-Position: refs/heads/master@{#292080}
Remove implicit conversions from scoped_refptr to T* in content/renderer/media/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/480233007
Cr-Commit-Position: refs/heads/master@{#292079}
Video Player: Add null-check on playback error
BUG=none
TEST=none
TBR=fukino@chromium.org
Review URL: https://codereview.chromium.org/507173004
Cr-Commit-Position: refs/heads/master@{#292078}
Rename RootViewManager to DisplayManager
DisplayManager is a better name for what the object is intended to do.
BUG=none
TEST=none
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/510483003
Cr-Commit-Position: refs/heads/master@{#292077}
Remove implicit conversions from scoped_refptr to T* in cloud_print/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/513503002
Cr-Commit-Position: refs/heads/master@{#292076}
Adjust border of the experimental app list search box.
This CL makes the bottom border of the experimental app list search box darker and thinner.
BUG=406222
Review URL: https://codereview.chromium.org/491013004
Cr-Commit-Position: refs/heads/master@{#292075}
Remove OpenSSL.
(It's now BoringSSL in third_party/boringssl.)
BUG=none
Review URL: https://codereview.chromium.org/513513002
Cr-Commit-Position: refs/heads/master@{#292074}
Add the mp2t mimetype to the list of supported mime types.
The mp2t mimetype is now supported when the mpeg2 TS stream parser is enabled.
This change is required since isTypeSupported involves
that CanPlayType for the same mime type is at least maybe.
This condition is now enforced at Blink level.
BUG=None
Review URL: https://codereview.chromium.org/478043005
Cr-Commit-Position: refs/heads/master@{#292073}
Part 3: Merged FakedDBusThreadManager with DBusThreadManager.
BUG=401192
TEST=existing tests
TBR=sky,stevenjb,keybuk
Review URL: https://codereview.chromium.org/477663004
Cr-Commit-Position: refs/heads/master@{#292072}
NaCl: Update revision in DEPS, r13655 -> r13666
This pulls in the following Native Client changes:
r13657: (sbc) Disable two glibc tests: tst-truncate and tst-truncate64
r13658: (jvoung) Avoid up/downloading scratch copy of pnaclmm.bc from generating libpnaclmm.a.
r13659: (mseaborn) Use uint32_t for untrusted pointer args: read() and write() syscalls
r13660: (mseaborn) PNaCl dynamic loader: Fix a corner case with mapping the BSS
r13661: (kschimpf) Update revision for PNaCl r13647->r13658
r13666: (dyen) Added initial implementation of the IRT extension interface.
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_cross_compile,linux_nacl_sdk_build
TBR=ncbray@chromium.org
Review URL: https://codereview.chromium.org/509703003
Cr-Commit-Position: refs/heads/master@{#292071}
events: keycodes: Remove the stateless singleton instance of KeycodeConverter
All methods can be safely made static and the singleton
removed.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/494813002
Cr-Commit-Position: refs/heads/master@{#292070}
Exclude tests that deadlock under DrMemory (and Tsan)
BUG=407452
TBR=xhwang@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/509793002
Cr-Commit-Position: refs/heads/master@{#292069}
Chromecast buildfix: MetricsService has moved to metrics namespace.
R=isherman@chromium.org,lcwu@chromium.org
BUG=374763
Review URL: https://codereview.chromium.org/510483004
Cr-Commit-Position: refs/heads/master@{#292068}
Use a qualified path for chromium_strings, google_chrome_strings, and generated_resources. (part 2 of 2)
BUG=401588
Review URL: https://codereview.chromium.org/498773003
Cr-Commit-Position: refs/heads/master@{#292067}
Fix a bug where an AppWindow* was not being properly deleted in the BrowserProcessPowerTest.AppsRecordPowerUsage test.
NOTRY=true
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/507773006
Cr-Commit-Position: refs/heads/master@{#292066}
Disable failing CastV2Performance tests.
BUG=356842
TBR=hubbe@chromium.org
Review URL: https://codereview.chromium.org/506363002
Cr-Commit-Position: refs/heads/master@{#292065}
Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/505913002
Cr-Commit-Position: refs/heads/master@{#292064}
app_shell: Add version number in user agent
Some sites sniff the Chrome version number, so app_shell needs to
provide one.
BUG=407236
TEST=app_shell_unittests ShellContentClientTest.UserAgentFormat
Review URL: https://codereview.chromium.org/505403003
Cr-Commit-Position: refs/heads/master@{#292063}
Fix a couple small problems with tools/unused-grit-header.py.
- Checking the wrong nodes due to a typo in the previous code review.
- Handle the case of GRD files that do not emit a header file.
NOTRY=true
Review URL: https://codereview.chromium.org/510623002
Cr-Commit-Position: refs/heads/master@{#292062}
app_shell: Allow getUserMedia to select a capture device by id
Return the device if it exists. Still return the first available device
if getUserMedia() doesn't ask for one in particular.
BUG=407236
TEST=manual
Review URL: https://codereview.chromium.org/514463002
Cr-Commit-Position: refs/heads/master@{#292061}
BrowserPlugin: Simplify guest access
Now that it's impossible for content to create guests and it's impossible
for a compromised embedder to access a guest it does not have permission to
access from content, BrowserPluginGuestManager::MaybeGetGuestByInstanceIDOrKill
seems a bit heavy-handed. This CL simplifies the API a bit.
This is also a prerequiste to support accessibility in BrowserPlugin.
BUG=226145
Review URL: https://codereview.chromium.org/511643002
Cr-Commit-Position: refs/heads/master@{#292060}
Revert "Split bundle generation steps so that API registration is generated in browser, not common."
Causing build failure in Android due to failed include for extensions/common/api/runtime.h.
This reverts commit 3b70ef14be986a3252428cc6d9553bf2c69deb70.
BUG=none
TBR=yoz
Review URL: https://codereview.chromium.org/506253003
Cr-Commit-Position: refs/heads/master@{#292059}
Update syslog parser for new ChromeOS log format
In R39, ChromeOS rsyslogd no longer includes the hostname
field. Update SyslogParser accordingly.
While there:
- Update example shill log message to include process ID.
(ChromeOS syslog recently started recording process IDs
whenever possible.)
- Add a test log message from the kernel. This message does
not include a process ID.
- Fix parsing of messages that do not have a process ID.
Previously, for such messages, the process name would include
a trailing ':'. With this change, they no longer do. (The
process name will now be 'kernel', instead of 'kernel:'.)
- Simplify string EXPECTations. (No need for cstr() and STREQ.)
BUG=403558
TEST=unit test (ExtensionSyslogParserTest.ParseLog)
Review URL: https://codereview.chromium.org/486873005
Cr-Commit-Position: refs/heads/master@{#292058}
Split bundle generation steps so that API registration is generated in browser, not common.
We now have schema generation, schema bundle generation, and schema bundle registration generation; the last of these is generated in a separate build target and output to browser rather than common.
Fix a couple of dangling gyp issues also.
BUG=405226
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/489153003
Cr-Commit-Position: refs/heads/master@{#292057}
Fixes moving fully occluded windows when the a11y keyboard shows.
TEST=WorkspaceLayoutManagerKeyboardTest.AdjustWindowForA11yKeyboard
BUG=407094
Review URL: https://codereview.chromium.org/506133002
Cr-Commit-Position: refs/heads/master@{#292056}
Fix DesktopMediaPickerViews to handle background parent_web_contents
After r283702 DesktopMediaPickerViews is getting parent_web_contents even
when it corresponds to a background extension page.
DesktopMediaPickerViews was always trying to create a modal dialog when
web_contents is specified, and that doesn't work for background pages.
Now it explicitly checks if the web_contents is a background page and
in that case shows the picker in a separate window.
Also updated example for desktop capture API to make it easier to test
this scenario.
BUG=402579
Review URL: https://codereview.chromium.org/501713002
Cr-Commit-Position: refs/heads/master@{#292055}
Remove redundant echo.mojom, verify non-nullables in echo_service.mojom
While looking at mojom files I'm nominally the owner of, I realized
that one had become redundant. So, I just deleted it and checked the
other to make sure it had the right 'nullability' on the method args.
Also moved around code to build against the de-duped mojom file.
BUG=407673
TEST=build with gyp and gn
Review URL: https://codereview.chromium.org/503363004
Cr-Commit-Position: refs/heads/master@{#292054}
[webcrypto] Implement AES-CTR using BoringSSL.
BUG=399084
Review URL: https://codereview.chromium.org/491763002
Cr-Commit-Position: refs/heads/master@{#292053}
Remove implicit conversions from scoped_refptr to T* in sandbox/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/467183005
Cr-Commit-Position: refs/heads/master@{#292052}
Remove implicit conversions from scoped_refptr to T* in net/url_request/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/495093005
Cr-Commit-Position: refs/heads/master@{#292051}
Remove implicit conversions from scoped_refptr to T* in base/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/510563002
Cr-Commit-Position: refs/heads/master@{#292050}
Roll ICU to 291660
Rolled src/third_party/icu
from revision fdf0bb34eaddce23811770b987ecf95ee18572d6 to
revision a4ce5bf56788dbb4835a5ef6143384266bbff5f5
Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/icu52/+log/fdf0bb34eadd..a4ce5bf56788
TBR=thakis@chromium.org
BUG=82385
TEST=Build on Windows with clang and the above warning is not emitted
while building ICU
Review URL: https://codereview.chromium.org/493363005
Cr-Commit-Position: refs/heads/master@{#292049}
Surfaceless GLSurfaceOzone implementation.
BUG=380861
NOTRY=true
Review URL: https://codereview.chromium.org/498393003
Cr-Commit-Position: refs/heads/master@{#292048}
Revert of Improve the ScopedHandle verifier. (patchset #1 of https://codereview.chromium.org/506013004/)
Reason for revert:
All windows perf bots (official builds) crashing.
http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/73062/steps/generate_telemetry_profiles/logs/stdio
ChildEBP RetAddr
0022f7c0 6a3ffa19 chrome_69c90000!base::debug::BreakDebugger+0x10
0022f830 6a400622 chrome_69c90000!CheckIsChromeSxSProcess+0x26
0022f834 6a400d52 chrome_69c90000!InstallUtil::IsChromeSxSProcess+0x16
0022f83c 6a400c29 chrome_69c90000!BrowserDistribution::GetSpecificDistribution+0x3b
0022f844 6a3fe166 chrome_69c90000!BrowserDistribution::GetDistribution+0x7
0022f930 6a3fe11d chrome_69c90000!`anonymous namespace'::GetChromeChannelInternal+0x2c
0022f948 6a092c6c chrome_69c90000!GoogleUpdateSettings::GetChromeChannel+0x21
0022f9b4 6a08f70f chrome_69c90000!chrome::VersionInfo::GetChannel+0x60
0022f9b8 6a08f65a chrome_69c90000!`anonymous namespace'::UseHooks+0x5
0022f9dc 6a08eb5a chrome_69c90000!InstallCloseHandleHooks+0x15
0022fa20 00fb7623 chrome_69c90000!ChromeMain+0x3e
0022fab0 00fb7026 chrome!MainDllLoader::Launch+0x15f
0022faf4 00fd936a chrome!wWinMain+0x5a
0022fb40 766e338a chrome!__tmainCRTStartup+0xfd
WARNING: Stack unwind information not available. Following frames may be wrong.
0022fb4c 76f99f72 kernel32!BaseThreadInitThunk+0x12
0022fb8c 76f99f45 ntdll!RtlInitializeExceptionChain+0x63
0022fba4 00000000 ntdll!RtlInitializeExceptionChain+0x36
Original issue's description:
> Improve the ScopedHandle verifier.
>
> 1. Automate the selection of the proper channel to enable the verifier.
> Now the code is enabled at runtime.
>
> 2. Switch to a hash_map to track handles.
>
> 3. Intercept CloseHandle to detect the code that is closing handles owned
> by ScopedHandles. The initial implementation only covers chrome.exe/dll,
> but the plan is to extend that in the future to all modules loaded in the
> process.
>
> BUG=362176
> R=cpu@chromium.org
> R=sky@chromium.org
>
> See https://codereview.chromium.org/490043002/ for the actual review.
>
> TBR=cpu@chromium.org
> TBR=sky@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c928d0383db43f2f4baf8f9b24ed7454bf7eda64
TBR=cpu@chromium.org,sky@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=362176
Review URL: https://codereview.chromium.org/507893002
Cr-Commit-Position: refs/heads/master@{#292047}
Disable deadlock-y tests in TSan instead of just suppressing the error.
The tests actually deadlock in practice.
BUG=407452
TBR=xhwang@chromium.org
Review URL: https://codereview.chromium.org/507163002
Cr-Commit-Position: refs/heads/master@{#292046}
Remove implicit conversions from scoped_refptr to T* in net/disk_cache/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/508733002
Cr-Commit-Position: refs/heads/master@{#292045}
Expose IsSolidColor and write units tests
AnalysisRaster was needed because we must run the analysis on a separate
thread. My second attempt placed the analysis in the picturepileimpl,
but, as vmpstr predicted, this caused issues when software rasterizing
since it uses yet another thread. The way around all of this was to
write another raster function without the:
DCHECK(raster_thread_checker_.CalledOnValidThread());
We're calling the Analysis before any synchronization occures with impl
so it should be safe to call without the check.
BUG=396908
Review URL: https://codereview.chromium.org/494503002
Cr-Commit-Position: refs/heads/master@{#292044}
Removes unconditionally added chrome_run
It's no longer necessary as I fixed the underlying bug in the recipe
side.
BUG=407419
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/507853002
Cr-Commit-Position: refs/heads/master@{#292043}
Disable SandboxBPF.StartSingleThreadedAsMultiThreaded under TSan v2.
BUG=407357
TBR=rsesek@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/510473003
Cr-Commit-Position: refs/heads/master@{#292042}
Remove implicit conversions from scoped_refptr to T* in webkit/
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/488463005
Cr-Commit-Position: refs/heads/master@{#292041}
Don't use msmpeg2vdec.dll version 6.1.7140
This version of the dll seems to be causing a disproportionate number of
crashes, so we fall back to software decoding if that is the version of
the DLL on the user's machine.
BUG=403440
Review URL: https://codereview.chromium.org/502183002
Cr-Commit-Position: refs/heads/master@{#292040}
Skia roll 76db31a:2a65a23
https://skia.googlesource.com/skia/+log/76db31a2ca11da4dd45016e964b2e49f39f3dd49..2a65a238b0e688356aee09d08f3f8a317359b4d2
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/504223004
Cr-Commit-Position: refs/heads/master@{#292039}
Move app_shell specific impl from athena_lib to athena_shell_lib
* AppActivity is now base class. There will be one for chrome
* Moved content_activity_factory.h from public to impl as ther eis no need to expose header.
* Added CreateAppActivity that takes apps::Window. Chrome
impl will use this to create an activity. This simply returns NULL for app_shell version.
BUG=397167
R=mukai@chromium.org
TBR=jamescook@chromium.org
TEST=no functional change. all tests must pass.
Review URL: https://codereview.chromium.org/505273002
Cr-Commit-Position: refs/heads/master@{#292038}
Prevent CopyOutputRequest from crashing when using surfaces.
It was hitting a DCHECK when attempting to copy the CopyOutputRequest whenever navigating between pages.
BUG=
Review URL: https://codereview.chromium.org/511603002
Cr-Commit-Position: refs/heads/master@{#292037}
Move ExtensionActionStorageManager out of extension_action_api.*
There's really no reason to have these in the same file, and it's cluttering it
up.
Bonus:
- Convert ExtensionActionStorageManager to use a BrowserContext.
- Remove ExtensionActionStorageManager's ExtensionService dependency.
- Remove ExtensionActionStorageManager's public weak ptr interface
- Consolidate extension_misc:: ExtensionAction icon stuff and ExtensionActionAPI
icon stuff.
BUG=407290
Review URL: https://codereview.chromium.org/502033003
Cr-Commit-Position: refs/heads/master@{#292036}
IndexedDB: Cancel transaction inactivity timer on Commit() arrival
After processing a batch of requests, our IDB transaction initiates an
inactivity timer; if the timer fires before any further requests
arrive from the front-end we assume the front-end is wedged and abort
the transaction. The timer is be stopped on any new request, including
a signal to commit or abort. During the introduction of blobs, the
"stop timer on commit signal" ended towards the end of the commit
flow, but it should be towards the start so it doesn't fire if the
back-end is busy.
Speculative fix for frequent timeouts of W3C web-platform-tests seen
on slow bots.
R=cmumford@chromium.org
Review URL: https://codereview.chromium.org/502643003
Cr-Commit-Position: refs/heads/master@{#292035}
[Sync] Fix a crash when sign into sync.
The crash was caused by a dangling pointer to a deleted observer
registered by MostVisitedSites.
BUG=406996
Review URL: https://codereview.chromium.org/501973004
Cr-Commit-Position: refs/heads/master@{#292034}
Report on blacklist incidents.
BUG=394352
TEST=NONE
Review URL: https://codereview.chromium.org/433513008
Cr-Commit-Position: refs/heads/master@{#292033}
Use document from preview for System Dialog printing on Windows.
System dialog shows only properties of selected printers, no system dialog with printers.
Removed global Ctrl+Shift+P shortcut on windows.
BUG=374321
Review URL: https://codereview.chromium.org/480303002
Cr-Commit-Position: refs/heads/master@{#292032}
Bypass http cache for concurrent range requests.
Take over of https://codereview.chromium.org/232003002/, which
instead utilizes the seemingly new cache timeout logic.
All partial requests which hit net::ERR_IO_PENDING will now be
immediately timed out.
BUG=31014
TEST=layout tests, net_unittests, new unittest, manual.
Review URL: https://codereview.chromium.org/478763004
Cr-Commit-Position: refs/heads/master@{#292031}
net: HSTS list additions.
One special request for mygadgetguardian.lookout.com and an additional
Google domain.
Cr-Commit-Position: refs/heads/master@{#292030}
Set the shelf icon title explicitly for settings and task manager
This allows us to set the icon title (used for hovertext) independently
of the window title (which is empty for Settings windows).
BUG=406954
Review URL: https://codereview.chromium.org/507003002
Cr-Commit-Position: refs/heads/master@{#292029}
Only allow webrtc HW offload for H264 encode for extension process.
Add cmdline switch::kEnableWebRtcHWH264Encoding to control whether
to report WebRtc HW H264 encoding capability.
BUG=385941
R=xiyuan@chromium.org,kalman@chromium.org,posicak@chromium.org,jamesr@chromium.org
TBR=piman@chromium.org
Review URL: https://codereview.chromium.org/453063002
Cr-Commit-Position: refs/heads/master@{#292028}
Fix minor error in string formating while processing DEPS.
BUG=407662
NOTRY=true
Review URL: https://codereview.chromium.org/504223003
Cr-Commit-Position: refs/heads/master@{#292027}
Componentize component_updater: Move a bunch of tests to component.
BUG=371463
TBR=blundell
Review URL: https://codereview.chromium.org/493953002
Cr-Commit-Position: refs/heads/master@{#292026}
Revert "TestWebServer needs to use a free port."
Causing Android Build (dbg) findbugs to fail.
This reverts commit c4a3f88c4434e86057a8c7ae4e109b8be4138d8f.
BUG=none
TBR=hush
Review URL: https://codereview.chromium.org/514443002
Cr-Commit-Position: refs/heads/master@{#292025}
Mojo: add mojo_message_pipe_perftests
This is analogous to ipc_perftests. It measures roundtrip
time with various message sizes.
TEST=message_pipe_perftest.cc
R=viettrungluu@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/501983003
Cr-Commit-Position: refs/heads/master@{#292024}
Extend media::VideoFrame to wrap CVPixelBuffer on OS X and iOS.
This allows better integration of OS X and iOS media frameworks
with chromium code and makes buffer management less problematic,
especially when using CVPixelBufferPools provided by hardware
encoders or decoders.
BUG=401308
R=dalecurtis,hubbe
Review URL: https://codereview.chromium.org/446163003
Cr-Commit-Position: refs/heads/master@{#292023}
Removed redundant PrintingUIWebContentsObserver.
BUG=374321
Review URL: https://codereview.chromium.org/506273004
Cr-Commit-Position: refs/heads/master@{#292022}