Debian Bug report logs - #740673
apt-cdrom ident started requesting to insert cd even if cd is already mounted

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Gabriele Giacone <1o5g4r8o@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Tue, 4 Mar 2014 00:28:40 +0100

Package: apt
Version: 0.9.15.5
Severity: important
Tags: d-i
User: debian-hurd@lists.debian.org
Usertags: hurd
Control: found -1 0.9.15.2
Control: notfound -1 0.9.15.1

On hurd, "apt-cdrom ident" started requesting to insert cdrom even if cdrom is
already mounted.
That breaks debian-installer given it's called by load-install-cd.
Recent debian-installer builds get stuck at "Configuring apt - Scanning the
CD-ROM".
See https://bugs.debian.org/728153


root@hurd01:~# df /dev/hd2
Filesystem     1K-blocks   Used Available Use% Mounted on
/dev/hd2          660026 660026         0 100% /media/cdrom0
root@hurd01:~# apt-cdrom ident
Using CD-ROM mount point /media/cdrom/
Unmounting CD-ROM
Waiting for disc...
Please insert a Disc in the drive and press enter 		<<<<<<
Mounting CD-ROM...
Identifying.. [478550b67bb0515eb3936a92b05b79be-2]
Stored label: 
Unmounting CD-ROM...
root@hurd01:~# dpkg -i libapt-pkg4.12_0.9.15.1_hurd-i386.deb 
dpkg: warning: downgrading libapt-pkg4.12:hurd-i386 from 0.9.15.5 to 0.9.15.1
(Reading database ... 130961 files and directories currently installed.)
Preparing to unpack .../libapt-pkg4.12_0.9.15.1_hurd-i386.deb ...
Unpacking libapt-pkg4.12:hurd-i386 (0.9.15.1) over (0.9.15.5) ...
Setting up libapt-pkg4.12:hurd-i386 (0.9.15.1) ...
Processing triggers for libc-bin (2.18-3) ...
root@hurd01:~# apt-cdrom ident
Using CD-ROM mount point /media/cdrom/
Mounting CD-ROM
Identifying.. [478550b67bb0515eb3936a92b05b79be-2]
Stored label: 
Unmounting CD-ROM...

-- System Information:
Debian Release: jessie/sid
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable'), (1, 'experimental')
Architecture: hurd-i386 (i686-AT386)

Kernel: GNU-Mach 1.4-486-dbg/Hurd-0.5
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages apt depends on:
ii  debian-archive-keyring  2012.4
ii  gnupg                   1.4.16-1.1
ii  libapt-pkg4.12          0.9.15.5
ii  libc0.3                 2.18-3
ii  libgcc1                 1:4.8.2-16
ii  libstdc++6              4.8.2-16

apt recommends no packages.

Versions of packages apt suggests:
pn  apt-doc     <none>
ii  aptitude    0.6.10-1
ii  dpkg-dev    1.17.6
ii  python-apt  0.9.3.1
ii  xz-utils    5.1.1alpha+20120614-2

-- no debconf information

Message #12 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Gabriele Giacone <1o5g4r8o@gmail.com>

To: 740673@bugs.debian.org

Cc: debian-bsd@lists.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Tue, 4 Mar 2014 01:22:59 +0100

[ CC'ing debian-bsd@l.d.o ]

On Tue, Mar 04, 2014 at 12:28:40AM +0100, Gabriele Giacone wrote:
> Package: apt
> Version: 0.9.15.5
> Severity: important
> Tags: d-i
> User: debian-hurd@lists.debian.org
> Usertags: hurd
> Control: found -1 0.9.15.2
> Control: notfound -1 0.9.15.1
> 
> On hurd, "apt-cdrom ident" started requesting to insert cdrom even if cdrom is
> already mounted.
> That breaks debian-installer given it's called by load-install-cd.
> Recent debian-installer builds get stuck at "Configuring apt - Scanning the
> CD-ROM".
> See https://bugs.debian.org/728153

Just checked it affects kfreebsd-* as well. Here it also unmounts the cd.
My guess is it doesn't handle non-udev systems correctly.


root@kfreebsd-i386-01:~# mount -t cd9660 /dev/cd0 /media/cdrom
root@kfreebsd-i386-01:~# df /dev/cd0
Filesystem     1K-blocks   Used Available Use% Mounted on
/dev/cd0          662928 662928         0 100% /media/cdrom0
root@kfreebsd-i386-01:~# apt-cdrom ident
Using CD-ROM mount point /media/cdrom/
Unmounting CD-ROM
Waiting for disc...
Please insert a Disc in the drive and press enter		<<<<<<
Mounting CD-ROM...
E: Failed to mount the cdrom.
E: No CD-ROM could be auto-detected or found using the default mount point.
You may try the --cdrom option to set the CD-ROM mount point. See 'man apt-cdrom' for more information about the CD-ROM auto-detection and mount point.
root@kfreebsd-i386-01:~# df /dev/cd0
Filesystem     1K-blocks  Used Available Use% Mounted on
devfs                  1     1         0 100% /dev
root@kfreebsd-i386-01:~# dpkg -i libapt-pkg4.12_0.9.15.1_kfreebsd-i386.deb 
dpkg: warning: downgrading libapt-pkg4.12:kfreebsd-i386 from 0.9.15.4 to 0.9.15.1
(Reading database ... 113946 files and directories currently installed.)
Preparing to unpack libapt-pkg4.12_0.9.15.1_kfreebsd-i386.deb ...
Unpacking libapt-pkg4.12:kfreebsd-i386 (0.9.15.1) over (0.9.15.4) ...
Setting up libapt-pkg4.12:kfreebsd-i386 (0.9.15.1) ...
Processing triggers for libc-bin (2.17-97) ...
root@kfreebsd-i386-01:~# mount -t cd9660 /dev/cd0 /media/cdrom
root@kfreebsd-i386-01:~# df /dev/cd0
Filesystem     1K-blocks   Used Available Use% Mounted on
/dev/cd0          662928 662928         0 100% /media/cdrom0
root@kfreebsd-i386-01:~# apt-cdrom ident
Using CD-ROM mount point /media/cdrom/
Mounting CD-ROM
Identifying.. [92303d2a8bd9fa0131c5c7f9c7ab3848-2]
Stored label: 
Unmounting CD-ROM...
root@kfreebsd-i386-01:~# 

Message #19 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Gabriele Giacone <1o5g4r8o@gmail.com>

To: 740673@bugs.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Wed, 5 Mar 2014 20:30:02 +0100

On Tue, Mar 04, 2014 at 12:28:40AM +0100, Gabriele Giacone wrote:
> See https://bugs.debian.org/728153

Just to be more clear, commit which breaks apt-cdrom ident on hurd is

http://anonscm.debian.org/gitweb/?p=apt/apt.git;a=commitdiff;h=62dcbf84c4aee8cb01e40c594d4c7f3a23b64836

Message #24 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Samuel Thibault <sthibault@debian.org>

Cc: 740673@bugs.debian.org

Subject: Re: fixed 740673 in 0.9.15.1

Date: Sat, 8 Mar 2014 01:25:32 +0100

[Message part 1 (text/plain, inline)]

Control: notfixed 740673 0.9.15.1

Samuel Thibault <sthibault@debian.org> (2014-03-04):
> fixed 740673 0.9.15.1

Err, I'm pretty sure a bug can't be "fixed" in a version where it wasn't introduced yet…

Mraw,
KiBi.

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Gabriele Giacone <1o5g4r8o@gmail.com>, 740673@bugs.debian.org

Cc: debian-hurd@lists.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Sat, 8 Mar 2014 01:37:22 +0100

[Message part 1 (text/plain, inline)]

Control: severity -1 grave

Rationale: breaks all cdimage builds.

Gabriele Giacone <1o5g4r8o@gmail.com> (2014-03-04):
> Package: apt
> Version: 0.9.15.5
> Severity: important
> Tags: d-i
> User: debian-hurd@lists.debian.org
> Usertags: hurd

FWIW this isn't hurd-specific.

> On hurd, "apt-cdrom ident" started requesting to insert cdrom even if cdrom is
> already mounted.
> That breaks debian-installer given it's called by load-install-cd.
> Recent debian-installer builds get stuck at "Configuring apt - Scanning the
> CD-ROM".
> See https://bugs.debian.org/728153

Weekly installation image builds are indeed broken; this is slightly
annoying since I was aiming at releasing an alpha 1 image for jessie
soon, so that we can perform regression tests against it.

On a wheezy amd64 installation image, d-i's syslog says:
| Mar  8 00:10:35 apt-setup: umount: can't umount /target/media/cdrom0: Invalid argument
| Mar  8 00:10:35 apt-setup: Using CD-ROM mount point /media/cdrom/
| Mar  8 00:10:35 apt-setup: Identifying.. 
| Mar  8 00:10:35 kernel: [   98.432287] ISO 9660 Extensions: Microsoft Joliet Level 3
| Mar  8 00:10:35 kernel: [   98.432799] ISO 9660 Extensions: RRIP_1991A
| Mar  8 00:10:35 apt-setup: [925dbb4f8c3f5332e76734f22eddc145-2]
| Mar  8 00:10:35 apt-setup: Scanning disc for index files..
| Mar  8 00:10:35 apt-setup: Found 1 package indexes, 0 source indexes, 1 translation indexes and 0 signatures
| Mar  8 00:10:35 apt-setup: This disc is called: 
| Mar  8 00:10:35 apt-setup: 'Debian GNU/Linux 7.4.0 _Wheezy_ - Official amd64 NETINST Binary-1 20140208-13:45'
| Mar  8 00:10:35 apt-setup: Copying package lists...
| Mar  8 00:10:35 apt-setup: ^MReading Package Indexes... 0%^M
| Mar  8 00:10:35 apt-setup: ^MReading Package Indexes... 1%^M
| Mar  8 00:10:35 apt-setup: ^MReading Package Indexes... Done^M
| Mar  8 00:10:35 apt-setup: 
| Mar  8 00:10:35 apt-setup: ^MReading Translation Indexes... 0%^M
| Mar  8 00:10:35 apt-setup: ^MReading Translation Indexes... Done^M
| Mar  8 00:10:35 apt-setup: 
| Mar  8 00:10:35 apt-setup: Writing new source list
| Mar  8 00:10:35 apt-setup: Source list entries for this disc are:
| Mar  8 00:10:35 apt-setup: deb cdrom:[Debian GNU/Linux 7.4.0 _Wheezy_ - Official amd64 NETINST Binary-1 20140208-13:45]/ wheezy main
| Mar  8 00:10:35 apt-setup: Repeat this process for the rest of the CDs in your set.
| Mar  8 00:10:35 kernel: [   98.611009] ISO 9660 Extensions: Microsoft Joliet Level 3
| Mar  8 00:10:35 kernel: [   98.611568] ISO 9660 Extensions: RRIP_1991A

and stuff continues. On a jessie weekly amd64 installation image (built
2014-03-03), one gets this instead:
| Mar  8 00:04:02 apt-setup: umount: can't umount /target/media/cdrom0: Invalid argument
| Mar  8 00:04:02 apt-setup: Using CD-ROM mount point /media/cdrom/
| Mar  8 00:04:02 apt-setup: Unmounting CD-ROM
| Mar  8 00:04:02 apt-setup: Waiting for disc...
| Mar  8 00:04:02 apt-setup: Please insert a Disc in the drive and press enter  
| Mar  8 00:04:02 apt-setup: 
| Mar  8 00:04:02 apt-setup: Mounting CD-ROM...
| Mar  8 00:04:02 apt-setup: Identifying.. 
| Mar  8 00:04:02 kernel: [  103.820796] ISO 9660 Extensions: Microsoft Joliet Level 3
| Mar  8 00:04:02 kernel: [  103.821442] ISO 9660 Extensions: RRIP_1991A
| Mar  8 00:04:02 apt-setup: [6c0eb3539a58e533556f373c12bee688-2]
| Mar  8 00:04:02 apt-setup: Scanning disc for index files..
| Mar  8 00:04:02 apt-setup: Found 1 package indexes, 0 source indexes, 1 translation indexes and 0 signatures
| Mar  8 00:04:02 apt-setup: This disc is called: 
| Mar  8 00:04:02 apt-setup: 'Debian GNU/Linux testing _Jessie_ - Official Snapshot amd64 NETINST Binary-1 20140303-06:00'
| Mar  8 00:04:02 apt-setup: Copying package lists...
| Mar  8 00:04:02 apt-setup: ^MReading Package Indexes... 0%^M
| Mar  8 00:04:02 apt-setup: ^MReading Package Indexes... 1%^M
| Mar  8 00:04:02 apt-setup: ^MReading Package Indexes... Done^M
| Mar  8 00:04:02 apt-setup: 
| Mar  8 00:04:02 apt-setup: ^MReading Translation Indexes... 0%^M
| Mar  8 00:04:02 apt-setup: ^MReading Translation Indexes... Done^M
| Mar  8 00:04:02 apt-setup: 
| Mar  8 00:04:02 apt-setup: Writing new source list 
| Mar  8 00:04:02 apt-setup: Source list entries for this disc are:
| Mar  8 00:04:02 apt-setup: deb cdrom:[Debian GNU/Linux testing _Jessie_ - Official Snapshot amd64 NETINST Binary-1 20140303-06:00]/ jessie main
| Mar  8 00:04:02 apt-setup: Unmounting CD-ROM... 
| Mar  8 00:04:02 apt-setup: Repeat this process for the rest of the CDs in your set.


Your changelog says:
|   [ John Ogness ]
|   * apt-cdrom should succeed if any drive succeeds (Closes: 728153)

And more precisely:
| Author: John Ogness <john.ogness@linutronix.de>
| Date:   Fri Dec 13 20:59:31 2013 +0100
| 
|     apt-cdrom should succeed if any drive succeeds
|     
|     If there are multiple CD-ROM drives, `apt-cdrom add` will abort with an
|     error if any of the drives do not contain a Debian CD which is against
|     the documentation we have saying "a CD-ROM" and also scripts do not
|     expect it this way.
|     
|     This patch modifies apt-cdrom to return success if any of the drives
|     succeeded. If failures occur, apt-cdrom will still continue trying all
|     the drives and report the last failure (if none of them succeeded).
|     
|     The 'ident' command was also changed to match the new 'add' behavior.
|     
|     Closes: 728153

I'm pretty sure making "apt-cdrom ident" hang wasn't part of the plan,
and that's what's happening nonetheless when called from apt-setup's
generators/40cdrom script.

[ Also, if you're going to change semantics, it probably would be nice
to warn your users (e.g. -boot@ in that particular case); heads-up on
topics with possible big consequences are always appreciated. ]

Mraw,
KiBi.

[signature.asc (application/pgp-signature, inline)]

Message #48 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: 740673@bugs.debian.org

Subject: Re: Bug#740673: fixed 740673 in 0.9.15.1

Date: Sat, 8 Mar 2014 02:26:38 +0100

Cyril Brulebois, le Sat 08 Mar 2014 01:25:32 +0100, a écrit :
> Control: notfixed 740673 0.9.15.1
> 
> Samuel Thibault <sthibault@debian.org> (2014-03-04):
> > fixed 740673 0.9.15.1
> 
> Err, I'm pretty sure a bug can't be "fixed" in a version where it wasn't introduced yet…

Well, it was mostly to document that it was really tested as working as
of that version.

Samuel

Message #53 received at 740673@bugs.debian.org (full text, mbox, reply):

From: David Kalnischkies <david@kalnischkies.de>

To: Cyril Brulebois <kibi@debian.org>, 740673@bugs.debian.org

Cc: John Ogness <john.ogness@linutronix.de>

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Sat, 8 Mar 2014 16:36:26 +0100

[Message part 1 (text/plain, inline)]

On Sat, Mar 08, 2014 at 01:37:22AM +0100, Cyril Brulebois wrote:
> Gabriele Giacone <1o5g4r8o@gmail.com> (2014-03-04):
> > On hurd, "apt-cdrom ident" started requesting to insert cdrom even if cdrom is
> > already mounted.
> > That breaks debian-installer given it's called by load-install-cd.
> > Recent debian-installer builds get stuck at "Configuring apt - Scanning the
> > CD-ROM".
> > See https://bugs.debian.org/728153
> 
> Weekly installation image builds are indeed broken; this is slightly
> annoying since I was aiming at releasing an alpha 1 image for jessie
> soon, so that we can perform regression tests against it.

Sorry about that. I am not really able to test cdrom stuff at the moment
and had hoped that this was actually tested with d-i as the buglog
indicated this to me (yes I know, silly me). John, as the author of the
patch, can you shine some light on with what you have tested this (out
of my interest). One of your mails suggested to me it was useful for
d-i, but now that I read it again I seem to have overlooked a
"possibly".

(btw: I had shortly looked at the bug before, but couldn't find anything
 with a "non-udev codepath" POV, so that cluebat here really helped)


> And more precisely:
> | Author: John Ogness <john.ogness@linutronix.de>
> | Date:   Fri Dec 13 20:59:31 2013 +0100
> | 
> |     apt-cdrom should succeed if any drive succeeds
> |     
> |     If there are multiple CD-ROM drives, `apt-cdrom add` will abort with an
> |     error if any of the drives do not contain a Debian CD which is against
> |     the documentation we have saying "a CD-ROM" and also scripts do not
> |     expect it this way.
> |     
> |     This patch modifies apt-cdrom to return success if any of the drives
> |     succeeded. If failures occur, apt-cdrom will still continue trying all
> |     the drives and report the last failure (if none of them succeeded).
> |     
> |     The 'ident' command was also changed to match the new 'add' behavior.
> |     
> |     Closes: 728153
> 
> I'm pretty sure making "apt-cdrom ident" hang wasn't part of the plan,
> and that's what's happening nonetheless when called from apt-setup's
> generators/40cdrom script.

Mhh, I see. Me and my "lets reduce code duplication" stricking again.
I guess you can give apt-cdrom ident /dev/null as stdin as you do for
add to hotfix that for the moment (but not tested).

Will have to do some code-staring to find out what is really messed up
as I see this "Please insert a Disc in the drive and press enter" in the
new output of the add command only, but the code for it is in the old
one as well. And my impression is that it shouldn't be in any. Fishy.

At least it reminds me that I have to find a way to make a testcase which
doesn't use --no-mount as this is of course hiding the issue…

Sidenote: Why are you allowing apt-cdrom to do the mounting by itself
here if you have mounted it already and remount it after the run?


> [ Also, if you're going to change semantics, it probably would be nice
> to warn your users (e.g. -boot@ in that particular case); heads-up on
> topics with possible big consequences are always appreciated. ]

It wasn't supposed to change semantics - at least not in a negative way.
If you have one drive nothing changes (at least that was the idea) and
if you have two apt-cdrom will not fail if it looks at the empty drive
first - which sounds like a good idea and should be fine for d-i (and
even fix some issues as mentioned in the buglog with it) if it would
work as intended.

Beside: I have to admit that I don't know who is using apt and how.
I get a remote idea of what is using apt and how each time we "break"
something (like description fieldname in 'apt-cache show' for cdrom
creation scripts), but as much as I would like to, I can't remember them
all and especially can't test them all. And I am pretty sure you don't
want to be cc'ed on all changes in apt just because I have no idea what
could possibly break if I change anything (as the fieldname example
shows, I can't assume anything in general). So sorry again for the
trouble caused, but please don't assume bad faith here…

Sidenote: The manpage says 'ident' is "a debugging tool". You will
hopefully understand that even if I had anticipated that the commit
would cause trouble I would have assumed nobody would use it.
(I see now that apt-setup is using it and why, and while the information
 is in the add output as well it is probably a bit harder to get it from
 there, point taken, but that this is easy to say after the fact)


Best regards

David Kalnischkies

[signature.asc (application/pgp-signature, inline)]

Message #58 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>

To: Cyril Brulebois <kibi@debian.org>

Cc: 724931@bugs.debian.org, 740673@bugs.debian.org, Christian PERRIER <bubulle@debian.org>

Subject: Re: Bug#724931: Please include the patch in git

Date: Sat, 08 Mar 2014 20:40:14 +0100

Hi,

On 08.03.2014 19:04, Cyril Brulebois wrote:
> Andreas Cadhalpun <andreas.cadhalpun@googlemail.com> (2014-03-08):
>> I generally agree that it would be good to have an alpha 1 installer
>> to use for testing regressions of this patch, but on the other hand
>> using loopmount to install Debian *works*.
>
> Sorry, but until it's been pushed to the masses, I can't blindly trust
> that. Many moving parts already, not going to add a critical one when
> we already have a (known) regression in apt-setup/apt-cdrom. Especially
> not a few days before a release.

I didn't really suggest applying the patch without further testing from 
someone other than me. I just wanted to express my amazement that 
loopmount works, while the usual way doesn't.

I looked more closely and found that commenting out the following in 
40cdrom fixes the problem:
	# Allow apt-cdrom to manage mounting/unmounting CDs in /target
	if [ "$cd_mountable" ]; then
		rm -f $ROOT/etc/apt/apt.conf.d/00NoMountCDROM

		$logoutput umount /target/media/cdrom* || true
		$logoutput umount /cdrom || true
	fi

At least I managed to install Debian jessie in a Virtual Machine.
So if there are no compelling reasons to have this (Note: I don't know, 
what this is supposed to do.), I would suggest removing this as a fix 
for Bug #740673.

Best regards,
Andreas

Message #63 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>

Cc: 724931@bugs.debian.org, 740673@bugs.debian.org, Christian PERRIER <bubulle@debian.org>

Subject: Re: Bug#724931: Please include the patch in git

Date: Sat, 8 Mar 2014 20:49:35 +0100

[Message part 1 (text/plain, inline)]

Andreas Cadhalpun <andreas.cadhalpun@googlemail.com> (2014-03-08):
> I looked more closely and found that commenting out the following in
> 40cdrom fixes the problem:
> 	# Allow apt-cdrom to manage mounting/unmounting CDs in /target
> 	if [ "$cd_mountable" ]; then
> 		rm -f $ROOT/etc/apt/apt.conf.d/00NoMountCDROM
> 
> 		$logoutput umount /target/media/cdrom* || true
> 		$logoutput umount /cdrom || true
> 	fi
> 
> At least I managed to install Debian jessie in a Virtual Machine.
> So if there are no compelling reasons to have this (Note: I don't
> know, what this is supposed to do.), I would suggest removing this
> as a fix for Bug #740673.

Err, no.

We had something that worked well enough for a while, it broke due to a
change in apt-cdrom, which was confirmed to be unintentional. So let's
fix that for now, and *maybe* rethink stuff after that.

I'm not goint to drop random lines, especially not based on “I don't
know what this is supposed to do”…

Mraw,
KiBi.

[signature.asc (application/pgp-signature, inline)]

Message #68 received at 740673@bugs.debian.org (full text, mbox, reply):

From: John Ogness <john.ogness@linutronix.de>

To: David Kalnischkies <david@kalnischkies.de>

Cc: Cyril Brulebois <kibi@debian.org>, 740673@bugs.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Sun, 09 Mar 2014 18:22:50 +0100

On 2014-03-08, David Kalnischkies <david@kalnischkies.de> wrote:
> On Sat, Mar 08, 2014 at 01:37:22AM +0100, Cyril Brulebois wrote:
>> Gabriele Giacone <1o5g4r8o@gmail.com> (2014-03-04):
>> > On hurd, "apt-cdrom ident" started requesting to insert cdrom even if cdrom is
>> > already mounted.
>> > That breaks debian-installer given it's called by load-install-cd.
>> > Recent debian-installer builds get stuck at "Configuring apt - Scanning the
>> > CD-ROM".
>> > See https://bugs.debian.org/728153
>> 
>> Weekly installation image builds are indeed broken; this is slightly
>> annoying since I was aiming at releasing an alpha 1 image for jessie
>> soon, so that we can perform regression tests against it.
>
> Sorry about that. I am not really able to test cdrom stuff at the moment
> and had hoped that this was actually tested with d-i as the buglog
> indicated this to me (yes I know, silly me). John, as the author of the
> patch, can you shine some light on with what you have tested this (out
> of my interest). One of your mails suggested to me it was useful for
> d-i, but now that I read it again I seem to have overlooked a
> "possibly".

I tested apt-cdrom add with d-i for my original patch, since the problem
I was solving was for d-i. You then asked me to change ident as
well. I did not test the ident changes with d-i, only from various tests
on the command line.

I will look at how d-i is using ident and see what the problem is.

> At least it reminds me that I have to find a way to make a testcase
> which doesn't use --no-mount as this is of course hiding the issue…
>
> Sidenote: Why are you allowing apt-cdrom to do the mounting by itself
> here if you have mounted it already and remount it after the run?

While making the code changes, the handling of no-mount seemed odd to
me, as if it was being used as some special case for some application
and was not really a general-purpose feature. And it was different for
"add" than it was for "ident". Now "ident" behaves like "add" which is
probably the problem. I thought I was fixing buggy behavior for code
that nobody used.

>> [ Also, if you're going to change semantics, it probably would be
>> nice to warn your users (e.g. -boot@ in that particular case);
>> heads-up on topics with possible big consequences are always
>> appreciated. ]

This is my fault. I should have brought up the strange behavior of
"no-mount" and asked why it was like that. In fact, there are several
things about the "no-mount" implementation that should probably be
addressed because it is quite fragile code.

John Ogness

Message #73 received at 740673@bugs.debian.org (full text, mbox, reply):

From: John Ogness <john.ogness@linutronix.de>

To: 740673@bugs.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Thu, 13 Mar 2014 22:46:11 +0100

I have been studying both apt-cdrom and d-i to understand the
behavior.

Here are the problems that I see. I will be happy to implement/fix these
issues if we agree on the correct behavior.

1. According to the man page the purpose of APT::CDROM::NoMount is to
   "prevent apt-cdrom from mounting and unmounting the mount point". So
   in my opinion, if this option is enabled, apt-cdrom should *never*
   mount or unmount. (That was not true for "ident" until now.)

2. When "add" mounts a CD, it sometimes unmounts it and sometimes not,
   depending on which exit path is taken. This seems quite bizarre and
   should be made consistent. In my opinion it should be a simple rule:
   "add" always unmounts the CD when it is done.

3. The man page for "ident" is not clear about what is supposed to
   happen. The previous behavior was to mount it (regardless of
   APT::CDROM::NoMount) and then maybe unmount it. In my opinion it
   should behave like "add" should. If APT::CDROM::NoMount is enabled,
   there is no mounting/unmounting. If it is not enabled, it would
   unmount any mounted CD and ask the user to insert a new CD before
   mounting it and proceeding. By redirecting stdin to /dev/null the
   user-feedback step would be skipped (just like "add").

Implementing these changes is straight forward. However, they would also
require a change to d-i to redirect stdin to /dev/null for "ident" to
avoid user-feedback (just as d-i already does for "add").

May I submit patches for apt and d-i to implement these changes?

John Ogness

Message #78 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: John Ogness <john.ogness@linutronix.de>

Cc: David Kalnischkies <david@kalnischkies.de>, 740673@bugs.debian.org, debian-boot@lists.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Thu, 13 Mar 2014 22:46:55 +0100

[Message part 1 (text/plain, inline)]

Hi John and David.

First of all: Sorry, I probably was or at least sounded way too grumpy;
I can only agree with the fact it was obviously broken *to me* because
that's a feature d-i uses and people noticed. That wasn't a reason to
be mad at people trying to fix bugs and to improve software. Sorry again
about that.

John Ogness <john.ogness@linutronix.de> (2014-03-09):
> I will look at how d-i is using ident and see what the problem is.
> 
> > At least it reminds me that I have to find a way to make a testcase
> > which doesn't use --no-mount as this is of course hiding the issue…
> >
> > Sidenote: Why are you allowing apt-cdrom to do the mounting by itself
> > here if you have mounted it already and remount it after the run?
> 
> While making the code changes, the handling of no-mount seemed odd to
> me, as if it was being used as some special case for some application
> and was not really a general-purpose feature. And it was different for
> "add" than it was for "ident". Now "ident" behaves like "add" which is
> probably the problem. I thought I was fixing buggy behavior for code
> that nobody used.


KiBi's tests:
-------------
So, I've learnt about/deployed debian-cd locally, and I'm now able to
generate tweaked ISO allowing for a patched apt to be tested within d-i.

There were two commits touching apt-cdrom:
  [1] 62dcbf84c4aee8cb01e40c594d4c7f3a23b64836 apt-cdrom should succeed if any drive succeeds
  [2] ce55512d4924b52c985276c62a0c69ac13e203cd remove duplication in pkgCdrom::Add and ::Ident

On top of current debian/sid, I verified that:
  [1] applied  + [2] applied  = hang
  [1] applied  + [2] reverted = hang
  [1] reverted + [2] reverted = success

so the hang is not a result of code deduplication (commit [2]).

I then concentrated on “instrumenting” the functions touched by [1], so
as to determine where the hang was taking place, namely DoAdd() and
DoIdent(); basically, DoAdd() works just fine, DoIdent() is then run and
that's the one hanging, apparently in the Ident() call. Adding some more
“cout << ... << endl; ” calls to Ident(), it finally appeared that we're
stuck in the ChangeCdrom() call at this point, which is presumably
waiting for user input. This is rather consistent given that strace
reports that the process is blocking on a read() on fd 0.


You'll find attached the patch I've used against the current debian/sid
branch, including patch [1], and excluding patch [2]; and d-i's syslog,
stripped down (limit to the apt-setup part).

FWIW: I'm happy to test any apt patch you can come up with, and to post
the results in a d-i environment.


Important note on interactivity:
--------------------------------
I've noticed the “apt-cdrom add” we have in apt-setup has a final
“< /dev/null” to explicitly disable interactivity. I've tried patching
all “apt-cdrom ident” calls to include that redirection as well, which
affects the following files:
  generators/40cdrom
  generators/41cdset
  load-install-cd

I've generated an ISO with the updated udebs, and the default install
went through without any hangs. I've also verified half-way through
that packages available in the ISO were seen this way in /target by
apt, meaning only the missing packages were downloaded from the
configurer network mirror.

Initially, I wasn't too happy about patching apt-setup this late, but
the code deduplication commit points out that “apt-cdrom add” and
“apt-cdrom ident” are quite close, so maybe we should just release with
a patched apt-setup, disabling interactivity for all “apt-cdrom
{add,ident}” calls, and see how well it goes.


Do (apt/d-i) folks think this is crazy, or worth a try?

Mraw,
KiBi.

[apt+nmu5.diff (text/x-diff, attachment)]

[apt+stripped5.log (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #83 received at 740673-close@bugs.debian.org (full text, mbox, reply):

From: Michael Vogt <mvo@debian.org>

To: 740673-close@bugs.debian.org

Subject: Bug#740673: fixed in apt 0.9.16

Date: Fri, 14 Mar 2014 09:50:02 +0000

Source: apt
Source-Version: 0.9.16

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 740673@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 14 Mar 2014 09:45:05 +0100
Source: apt
Binary: apt libapt-pkg4.12 libapt-inst1.5 apt-doc libapt-pkg-dev libapt-pkg-doc apt-utils apt-transport-https
Architecture: source all amd64
Version: 0.9.16
Distribution: unstable
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Description: 
 apt        - commandline package manager
 apt-doc    - documentation for APT
 apt-transport-https - https download transport for APT
 apt-utils  - package management related utility programs
 libapt-inst1.5 - deb package format runtime library
 libapt-pkg-dev - development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - documentation for APT development
 libapt-pkg4.12 - package management runtime library
Closes: 661537 740673 740843 741056
Changes: 
 apt (0.9.16) unstable; urgency=medium
 .
   [ Michael Vogt ]
   * add hashsum support in apt-helper download-file and
     add more tests
 .
   [ Trần Ngọc Quân ]
   * l10n: vi.po (624t): Update Vietnamese translation
 .
   [ David Kalnischkies ]
   * propagate a negative score point along breaks/conflicts
   * check version before adding scores in resolver
   * autogenerate makefile for vendor system
   * add default and override handling for Cnf::FindVector
   * support DEB_BUILD_PROFILES and -P for build profiles
   * do not configure already unpacked packages needlessly (Closes: 740843)
   * if mountpoint has a ".disk" directory it is mounted
   * no error for non-existing mountpoints in MountCdrom
   * apt-cdrom ident shouldn't be interactive (Closes: 740673)
   * support very long mtab entries in mountpoint discovery
   * msgstr with elipses need three dots
   * cmdline parsing: apt-config is not apt-cdrom
   * use a configurable list of versioned kernel packages
   * support kfreebsd and hurd in the kernel hook
   * add ".*-{kernel,modules}-$KERVER" matcher for hook
   * ensure that a dot is a dot in the hook
   * use liblzma-dev to provide xz/lzma support
   * use the pretty fullname of a pkg as download desciption
 .
   [ Johannes Schauer ]
   * implement BuildProfileSpec support as dpkg has in 1.17.2 (Closes: 661537)
 .
   [ Wojciech Górski ]
   * fix polish --install-suggests text in apt-get manpage (Closes: 741056)
Checksums-Sha1: 
 131078a4e5bff780a8d5bfd5aac196a8a8177025 1638 apt_0.9.16.dsc
 88f89e8cec134b951371013ceb706ce1373771bd 1734784 apt_0.9.16.tar.xz
 c4e4720044a0434ccf803d7cb0cd9c261a0906bc 270724 apt-doc_0.9.16_all.deb
 d78931fa7027bc61c6fa96f1fc1693bcb117323e 766790 libapt-pkg-doc_0.9.16_all.deb
 d494798e128855de9735b5c5a1e415b616ffa880 743384 libapt-pkg4.12_0.9.16_amd64.deb
 dc1504c2f88e6d66439189d669603e2017fb96db 162490 libapt-inst1.5_0.9.16_amd64.deb
 81eedba06f88dcd121ab65354c7f552f266ace98 1062452 apt_0.9.16_amd64.deb
 64e38f60c3d90a35e53c67047f05c87de6190b33 186468 libapt-pkg-dev_0.9.16_amd64.deb
 2dfedef00f9920e14c78cbdd327841ee24c50069 349466 apt-utils_0.9.16_amd64.deb
 97530050b15f2d8f9b0f0cec4264d81f0b51ffc5 129148 apt-transport-https_0.9.16_amd64.deb
Checksums-Sha256: 
 c5f080a8f80ed969a5527a326b638f96ba4b26e4792710359a25d2e4d34916ac 1638 apt_0.9.16.dsc
 d6578c1510dcad6d63630e385e998384512da3c64fb09f8a381364e11f01c513 1734784 apt_0.9.16.tar.xz
 b4a348de3caa1a95ad11a8ce8496d0a4b0e496c020de764a627820708d7100e3 270724 apt-doc_0.9.16_all.deb
 02bbc61e603e3d299d9f42790c095fe58d586775a821273e0f5487b390e441df 766790 libapt-pkg-doc_0.9.16_all.deb
 184a24d86a7b2378ec3b16fb35a6b1ff8787697ced13214c28347ce42c94be5e 743384 libapt-pkg4.12_0.9.16_amd64.deb
 33ec9ac43621d9b3beba31f377641e60175f0b4e07f6c6928730201e63141140 162490 libapt-inst1.5_0.9.16_amd64.deb
 4751b238e7b06605fa159862b1595df856944f99ab6ce1a70f9642675e354d37 1062452 apt_0.9.16_amd64.deb
 a7ca0ea54f6e8a1f8edc13766bc038dc1f8be9707c41e826456f82443f77a048 186468 libapt-pkg-dev_0.9.16_amd64.deb
 c60caeb5519111acc151adb4c27d9ee281a279186f583ddfd25835b04d380ecb 349466 apt-utils_0.9.16_amd64.deb
 5c98075ba411007c11b6824ed0e5e903e89fa9a18bf2447a1ab0e14257d4c313 129148 apt-transport-https_0.9.16_amd64.deb
Files: 
 9d0f3f359fd7cbe973526c88e39ced44 1638 admin important apt_0.9.16.dsc
 9ebe9a76dac4fb453c030ee584756f6d 1734784 admin important apt_0.9.16.tar.xz
 bba391e04ef93fe3d7298981a0d9eb3d 270724 doc optional apt-doc_0.9.16_all.deb
 082f4caf75dc54e691a64ba5df570bce 766790 doc optional libapt-pkg-doc_0.9.16_all.deb
 3c413ad5c5fdabe0fb76035d76afac5f 743384 libs important libapt-pkg4.12_0.9.16_amd64.deb
 0aadeff033c0f147671938cf10ee6d0b 162490 libs important libapt-inst1.5_0.9.16_amd64.deb
 9bb168f072739ba11938c5e499d3f956 1062452 admin important apt_0.9.16_amd64.deb
 fde072f19e881b614ece35b4d1791cf5 186468 libdevel optional libapt-pkg-dev_0.9.16_amd64.deb
 098f3d2a85e9ec23f71670b45a69e8f8 349466 admin important apt-utils_0.9.16_amd64.deb
 ab1fcac9195fa6b2a6c0a491b52b9b84 129148 admin optional apt-transport-https_0.9.16_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlMixlcACgkQliSD4VZixzR8vQCfYggVmYiKG6ARbCwY8mChZTQU
S6UAn2gzGj23sBbN2MeKTtSREilvYZAx
=aFHK
-----END PGP SIGNATURE-----

Message #88 received at 740673@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: John Ogness <john.ogness@linutronix.de>

Cc: David Kalnischkies <david@kalnischkies.de>, 740673@bugs.debian.org, debian-boot@lists.debian.org

Subject: Re: Bug#740673: apt-cdrom ident started requesting to insert cd even if cd is already mounted

Date: Fri, 14 Mar 2014 12:10:03 +0100

[Message part 1 (text/plain, inline)]

Cyril Brulebois <kibi@debian.org> (2014-03-13):
> Important note on interactivity:
> --------------------------------
> I've noticed the “apt-cdrom add” we have in apt-setup has a final
> “< /dev/null” to explicitly disable interactivity. I've tried patching
> all “apt-cdrom ident” calls to include that redirection as well, which
> affects the following files:
>   generators/40cdrom
>   generators/41cdset
>   load-install-cd
> 
> I've generated an ISO with the updated udebs, and the default install
> went through without any hangs. I've also verified half-way through
> that packages available in the ISO were seen this way in /target by
> apt, meaning only the missing packages were downloaded from the
> configurer network mirror.
> 
> Initially, I wasn't too happy about patching apt-setup this late, but
> the code deduplication commit points out that “apt-cdrom add” and
> “apt-cdrom ident” are quite close, so maybe we should just release with
> a patched apt-setup, disabling interactivity for all “apt-cdrom
> {add,ident}” calls, and see how well it goes.
> 
> 
> Do (apt/d-i) folks think this is crazy, or worth a try?

So this commit landed in apt 0.9.16, uploaded today:
| commit b374004b8ffebe393c5fd5e8056f7a99849c0ebd
| Author: David Kalnischkies <david@kalnischkies.de>
| Date:   Mon Mar 10 00:09:56 2014 +0100
| 
|     apt-cdrom ident shouldn't be interactive
|     
|     Commit 62dcbf84 changed the code of ident to look more like the code for
|     add on my suggestion. This made ident interactive as it starts with a
|     unmount, press enter, mount cycle. The first two are skipped now.
|     This fixes d-i/apt-setup which is using it to get ID as well as label.
|     
|     Closes: 740673

Given it's bundled with a lot more changes, I don't feel like having apt
rushed into testing, so I'll probably push the “< /dev/null” bits to
apt-setup so as to disable interactivity from the caller, and get that
into testing urgently.

Mraw,
KiBi.

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.