Only preventDefault on click on [data-toggle="modal"] when the element is a link #10834
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is a link In it's current state Bootstrap always prevents the default action for a click event on `[data-toggle="modal"]` elements (see https://github.com/twbs/bootstrap/blob/master/js/modal.js#L233). Instead this should only happen when the element is a link.
fat
added a commit
that referenced
this pull request
Dec 27, 2013
Only preventDefault on click on [data-toggle="modal"] when the element is a link
|
makes sense to me, thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In it's current state Bootstrap always prevents the default action for a click event on
[data-toggle="modal"]elements (see https://github.com/twbs/bootstrap/blob/master/js/modal.js#L233). Instead this should only happen when the element is a link.Why? I'm opening a modal when the user chooses a particular radio button. But with the current Bootstrap version the radio button won't get selected, but the modal opens. I think the only reason why
preventDefaultis needed is to prevent the hash from appearing in the URL (and thus the browser from jumping to the top or said hash).