remove default left-right print margins per upstream h5bp change #12250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
added a commit
that referenced
this pull request
Jan 23, 2014
remove default left-right print margins per upstream h5bp change
|
@mdo So, do we actually need the vertical margins? |
|
Probably not tbh. Your tests from that other issue showed that browsers were super inconsistent as-is, so we should probably just defer to the user's custom margins (should they set them). |
mdo
added a commit
that referenced
this pull request
Jan 23, 2014
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
remove default left-right print margins per upstream h5bp change
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
remove default left-right print margins per upstream h5bp change
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Might help out with #12078.
I've left the top & bottom margins in for now, but they weren't in the h5bp code to begin with; we added them in 54561f1, but I'm not sure why. Do we still need them?
/to @mdo for review.