Options of sizes added in modal #11162
Conversation
| // Define small size for the modal | ||
| &.modal-sm{ | ||
| width: @modal-sm; | ||
| } |
There was a problem hiding this comment.
You don't need to chain these classes here—just set them after the .modal-dialog rules.
Also, include a space before those {s and drop the comments—they're not all that helpful since the classes are pretty clear.
There was a problem hiding this comment.
Really, I had put the class in the wrong place , sorry for error :p
|
Beyond adding the code here, we'll need to mention these (with classes and examples) in the docs. I'd also probably change the small to |
|
@mdo How are you? I followed your instructions, but the large sizes continues with 900px, if you want this size is smaller I make the adjustment. You check if this is correct? Thanks and congratulations for this awesome project. |
|
Without taking a look at modal, is it possible to use responsize sizes? so This makes things a lot better than defining set sizes. Also this would then be more suitable cross device as small is small on all devices etc. @jheytompkins |
|
Documented in d79431c. |
|
I also do something similar in my projects. |
|
@pholly That's been addressed in a more recent pull request. |
Hey Friends,
This time I believe the branches are organized correctly. =p
I imagine it would be interesting other size options for modal. I usually to add this option in my projects.
I added this functionality in modal and the possibility of set the size in "variables".
Thanks ; )